Fix time scale ticks.reverse issue #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
approved these changes
Dec 30, 2018
kurkle
approved these changes
Jan 1, 2019
kurkle
reviewed
Jan 1, 2019
| var scale = this.chart.scales.x; | ||
| expect(scale.getPixelForValue('2017')).toBeCloseToPixel(scale.left + scale.width); | ||
| expect(scale.getPixelForValue('2042')).toBeCloseToPixel(scale.left); | ||
| }); | ||
|
|
||
| it ('should reverse the bars and add offsets if offset is true', function() { |
There was a problem hiding this comment.
nit: bars when chart type is line.
|
Thanks @nagix |
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ticks.reverseis set totruein a time scale, there are a few issues:offsetis set totruebarThicknessis set to'flex'barThicknessis set to'flex'and there is only a single data pointThis PR fixes the issues above, and also improves the offset calculation when there is only one tick in a chart.
Master: https://jsfiddle.net/nagix/7kahbfcn/
This PR: https://jsfiddle.net/nagix/5ydbhwa7/